Skip to content
This repository has been archived by the owner on Jun 16, 2021. It is now read-only.

Tasks completed #33

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Tasks completed #33

wants to merge 25 commits into from

Conversation

AnonySharma
Copy link

@AnonySharma AnonySharma commented Apr 30, 2020 •
edited
Loading

CSOC Task 1 Submission

I have completed the following tasks

  • Login
  • auth_required.js and no_auth_required.js
  • Add Task
  • Get Tasks
  • Edit Task
  • Delete Task

@AnonySharma AnonySharma marked this pull request as ready for review April 30, 2020 17:38
@nishantwrp
Copy link
Member

Hi @AnonySharma,
I have gone through your app. Here are some suggestions.

  • There are two requests to the backend for profile. We only need one.
  • Extra requests to the backend on DELETE and UPDATE.
  • The edit input box should have the value of the current task.

Your score has been updated in the leaderboard.

@nishantwrp nishantwrp added the Judged The Pull Requests which are judged label May 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Judged The Pull Requests which are judged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnonySharma @nishantwrp