Skip to content
This repository has been archived by the owner on Jun 16, 2021. It is now read-only.

All Tasks completed #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

All Tasks completed #34

wants to merge 2 commits into from

Conversation

OVSRIKANTH
Copy link

CSOC Task 1 Submission

I have completed all tasks

@nishantwrp
Copy link
Member

Hi @OVSRIKANTH,
I have gone through your app. Here are some suggestions.

  • I was unable to login. I think you miss a return true; in your checkCredentialsAreValid function.
  • Your app doesn't work because of a syntax error in your code. You should have checked it before.

Your score has been updated in the leaderboard.

@nishantwrp nishantwrp added the Judged The Pull Requests which are judged label May 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Judged The Pull Requests which are judged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OVSRIKANTH @nishantwrp