Skip to content
This repository has been archived by the owner on Jun 16, 2021. It is now read-only.

Submitting CSOC Task 1 #8

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Submitting CSOC Task 1 #8

wants to merge 9 commits into from

Conversation

atpug22
Copy link
Member

@atpug22 atpug22 commented Apr 26, 2020 •
edited
Loading

CSOC Task 1 Submission

I have completed the following tasks

  • Login
  • auth_required.js and no_auth_required.js
  • Add Task
  • Get Tasks
  • Edit Task
  • Delete Task

@vercel
Copy link

vercel bot commented Apr 26, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shivanshs9/csoc-2020-task-1/gaf2z01mj
✅ Preview: https://csoc-2020-task-1-git-fork-atpug22-master.shivanshs9.now.sh

subodhk01
subodhk01 reviewed Apr 26, 2020
View reviewed changes
main.js Outdated Show resolved Hide resolved
subodhk01
subodhk01 reviewed Apr 26, 2020
View reviewed changes
main.js Outdated Show resolved Hide resolved
subodhk01
subodhk01 reviewed Apr 26, 2020
View reviewed changes
main.js Show resolved Hide resolved
subodhk01
subodhk01 reviewed Apr 26, 2020
View reviewed changes
main.js Outdated Show resolved Hide resolved
subodhk01
subodhk01 reviewed Apr 26, 2020
View reviewed changes
main.js Outdated Show resolved Hide resolved
subodhk01
subodhk01 reviewed Apr 26, 2020
View reviewed changes
init.js Show resolved Hide resolved
subodhk01
subodhk01 suggested changes Apr 26, 2020
View reviewed changes
Copy link
Member

@subodhk01 subodhk01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review the comments

@nishantwrp
Copy link
Member

Hey @atpug22,
Run these two commands for your deploy preview to be generated. (Change your commit message and force push)

  • git commit --amend
  • git push -f

@nishantwrp
Copy link
Member

nishantwrp commented Apr 30, 2020 •
edited
Loading

Hi @atpug22 ,
I have gone through your app. Here are some suggestions

  • There is no error when a person doesn't enter username and tries to login.
  • If a person submits same name in edit task. No request to backend should be made.

Your score has been updated in the leaderboard.

@nishantwrp nishantwrp added the Judged The Pull Requests which are judged label Apr 30, 2020
@ramrap
Copy link

ramrap commented May 1, 2020

@atpug22 lol

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@subodhk01 subodhk01 subodhk01 requested changes

Assignees
No one assigned
Labels
Judged The Pull Requests which are judged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atpug22 @nishantwrp @ramrap @subodhk01