Skip to content
This repository has been archived by the owner on Jun 16, 2021. It is now read-only.

Task 3 submission #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Task 3 submission #12

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented May 17, 2020

CSoC Task 3 Submission

I have completed the following tasks

  • Basic endpoints
  • Collaborator feature

@krashish8
Copy link
Member

Great work on the assignment @yashking007!
Here are some suggestions:

  • The register and login endpoint aren't working. There are errors, such as you haven't included the serializer_class etc.
  • In /todo/create POST endpoint, you should also return the Todo details along with the 200 Response.
  • You should create a separate file named permissions.py for including the permissions, instead of including the permissions in the views itself. However, this is fine for now.
  • In try-except block, you should capture only the exceptions which you want to catch (IndexError, IntegrityError, etc.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants