Skip to content
This repository has been archived by the owner on Jun 16, 2021. It is now read-only.

Completed Task #3 #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Completed Task #3 #2

wants to merge 3 commits into from

Conversation

atpug22
Copy link
Member

@atpug22 atpug22 commented May 14, 2020

CSoC Task 3 Submission

I have completed the following tasks

  • Basic endpoints
  • Collaborator feature

@krashish8 krashish8 temporarily deployed to csoc-task-3-master-8mzh7jgcaam May 14, 2020 18:25 Inactive
@krashish8
Copy link
Member

@atpug22 You have made changes to the model, but haven't created new migrations for that. Please run python manage.py makemigrations and push the newly created migrations.

@krashish8 krashish8 temporarily deployed to csoc-task-3-master-8mzh7jgcaam May 15, 2020 06:37 Inactive
@atpug22 atpug22 changed the title added collaborators and completed everything Completed Task #3 May 15, 2020
@nishantwrp
Copy link
Member

Hi @atpug22, Your api server is not working. I wasn't even able to register while testing. Please test your code before submitting. I've updated you score based on the code. Also here are some suggestions

  • You don't need to create a seperate table for collaboarators. A many_to_many field would have done.
  • I couldn't see collaborator feature implemented properly.
  • You could've used RetrieveUpdateDestroyAPIView in the TodoDetailView instead of writing the code separately for all of them.
  • Permissions were created but not used.

@atpug22
Copy link
Member Author

atpug22 commented May 22, 2020

Hi @atpug22, Your api server is not working. I wasn't even able to register while testing. Please test your code before submitting. I've updated you score based on the code. Also here are some suggestions

  • You don't need to create a seperate table for collaboarators. A many_to_many field would have done.
  • I couldn't see collaborator feature implemented properly.
  • You could've used RetrieveUpdateDestroyAPIView in the TodoDetailView instead of writing the code separately for all of them.
  • Permissions were created but not used.

Bhaiyaaa aap test kese kar rhe ho?
Mein jab local host pe simply request wagerah bhej rahaa to sab work kar rahaa thaa

@nishantwrp
Copy link
Member

I cloned your repo, applied the migrations, tried to register using swagger and it gave me 500 error.

@krashish8 krashish8 temporarily deployed to csoc-task-3-master-8mzh7jgcaam May 23, 2020 08:06 Inactive
@atpug22
Copy link
Member Author

atpug22 commented May 23, 2020

@nishantwrp bhaiya mene changes kar diye h ...aap ek baar aur check karle

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants