Skip to content
This repository has been archived by the owner on Jun 16, 2021. It is now read-only.

All Tasks Completed #task3 #5

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dasari810
Copy link

@dasari810 dasari810 commented May 15, 2020

CSoC Task 3 Submission

I have completed the following tasks

  • Basic endpoints
  • Collaborator feature

@dasari810
Copy link
Author

dasari810 commented May 17, 2020

In the collaboration api's provide the id of the choice you want to collaborate with and the username of the user you want to collaborate with ....same for the delete collaboration .

@dasari810 dasari810 changed the title Initial Commit #task3 All Tasks Completed #task3 May 17, 2020
@nishantwrp
Copy link
Member

Hi @MadhavaDasari,

  • I was unable to test all the endpoints. I was getting this response.
{
  "detail": "CSRF Failed: CSRF token missing or incorrect."
}

That was because of this change.

 'rest_framework.authentication.SessionAuthentication',

Can you please explain why did you need this?

  • Using /todo/{id}/add-collaboration/{user}/ endpoint with wrong id gives 500 error that should never happen.

  • Atleast the creator should be able to see all the collaborators.

  • There could be just 1 table Todo and collaborator could be a many to many field.

  • You didn't make a good use of serializers. Most of your logic is written in views.

  • You could have a permissions.py for handling the permissions.

Your score has been updated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants