Skip to content
This repository has been archived by the owner on Jun 16, 2021. It is now read-only.

All Tasks Completed #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

All Tasks Completed #6

wants to merge 3 commits into from

Conversation

king-11
Copy link
Member

@king-11 king-11 commented May 15, 2020

CSoC Task 3 Submission

I have completed the following tasks

  • Basic endpoints
  • Collaborator feature

@nishantwrp
Copy link
Member

Hi @king-11,
Awesome work! Here are some suggestions.

  • The register endpoints accepts empty names.
  • At least the owner should be able to see all the collaborators.
  • You didn't need a separate table for contributors.
  • Your way of validating users is good but permissions.py could've been better.

Your score has been updated

@king-11
Copy link
Member Author

king-11 commented May 23, 2020

@nishantwrp Thanks for the review will surely look into the suggestion for future projects. And regarding the collaborator model I made, actually the idea of ManyToMany Field struck me later when I was done with the assignment. So I just went with it actually 😅 as it was working fine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants