Skip to content
This repository has been archived by the owner on Nov 23, 2023. It is now read-only.

Feature/keybindings #143

Merged
merged 11 commits into from
Sep 5, 2023
Merged

Feature/keybindings #143

merged 11 commits into from
Sep 5, 2023

Conversation

CenturionLC
Copy link
Collaborator

Moved keybindings into settings page and configured it to persist across runtimes.

@CenturionLC CenturionLC added the scope: UI Related to the user interface label Sep 4, 2023
@CenturionLC CenturionLC added this to the UP DAY milestone Sep 4, 2023
@CenturionLC CenturionLC self-assigned this Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #143 (4bedec3) into dev (dfa299a) will decrease coverage by 0.04%.
Report is 7 commits behind head on dev.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #143      +/-   ##
==========================================
- Coverage   72.20%   72.17%   -0.04%     
==========================================
  Files          29       30       +1     
  Lines        1396     1405       +9     
  Branches      252      252              
==========================================
+ Hits         1008     1014       +6     
- Misses        336      339       +3     
  Partials       52       52              
Files Changed Coverage Δ
src/electron/utils/settings.ts 32.25% <ø> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@SharkmanZA SharkmanZA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CenturionLC CenturionLC merged commit 464beeb into dev Sep 5, 2023
15 checks passed
@ArmandKrynauw ArmandKrynauw deleted the feature/Keybindings branch September 20, 2023 21:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: UI Related to the user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants