This repository has been archived by the owner on Nov 23, 2023. It is now read-only.
Fix pane deletion bug causing exception in Splitpanes #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed integer pane id to string - Fix some index bugs with default layout creation - Fix BlipVane panel splitting direction bug - Clean up some code in the PanelGroup class
Rec1dite
approved these changes
Oct 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored some of the
PanelNodecode to use uniquely generated string id's instead of just integer counter id's. This seems to have fix the deletion exception bug. Might have been something to do with the #keyed blocks in Svelte not but not sure. Also found some one or two small bugs here and there that I fixed as well.