Pin sqlalchemy<2.0 #331
Merged
Pin sqlalchemy<2.0 #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #331 +/- ##
=======================================
Coverage 54.94% 54.94%
=======================================
Files 22 22
Lines 1811 1811
=======================================
Hits 995 995
Misses 816 816 ☔ View full report in Codecov by Sentry. |
|
@dougiesquire Will we try to support v2 at some point? Or we assume intake is the future? Just asking because the corresponding issue should be left open if the answer to the first question is yes. In any case, fine with me pinning the version, either temporarily or permanently. |
|
Hmmm I don't know. I have no intention to update to v2, but someone else might want to? You're right that the issue should probably be left open. I've changed that now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cosima-cookbook doesn't work with sqlalchemy 2 - see #320. This PR pins sqlalchemy to < 2.0.