Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for parcels 3.0.0 #307

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Updates for parcels 3.0.0 #307

merged 2 commits into from
Dec 13, 2023

Conversation

anton-seaice
Copy link
Collaborator

@anton-seaice anton-seaice commented Nov 2, 2023 •
edited
Loading

For moving to conda/analysis3-23.07, some updates are needed to use Parcels.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@review-notebook-app Review Notebook App
Copy link

review-notebook-app bot commented Nov 2, 2023 •
edited
Loading

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2023-11-02T17:29:39Z
----------------------------------------------------------------

where did this figure go?


anton-seaice commented on 2023-11-06T00:04:29Z
----------------------------------------------------------------

fixed

@review-notebook-app Review Notebook App
Copy link

review-notebook-app bot commented Nov 2, 2023 •
edited
Loading

View / edit / reply to this conversation on ReviewNB

navidcy commented on 2023-11-02T17:29:39Z
----------------------------------------------------------------

and the output here?


anton-seaice commented on 2023-11-06T00:04:37Z
----------------------------------------------------------------

fixed

navidcy
navidcy reviewed Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@navidcy navidcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wondering why a figure doesn't show up

@anton-seaice Review Notebook App
Copy link
Collaborator Author

fixed

View entire conversation on ReviewNB

@anton-seaice Review Notebook App
Copy link
Collaborator Author

fixed

View entire conversation on ReviewNB

@anton-seaice anton-seaice marked this pull request as ready for review November 6, 2023 00:05
@anton-seaice
Copy link
Collaborator Author

@hrsdawson Do you mind having a look I haven't broken anything? You'll need to set your module to conda/analysis-23.07

@anton-seaice anton-seaice self-assigned this Nov 6, 2023
@anton-seaice
Copy link
Collaborator Author

@hrsdawson Do you have time to review this? Hopefully its quick!

@navidcy navidcy self-requested a review December 13, 2023 10:55
navidcy
navidcy approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@navidcy navidcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@navidcy navidcy added the 🛸 updating An existing notebook needs to be updated label Dec 13, 2023
@navidcy navidcy changed the title updates for parcels 3.0.0 Updates for parcels 3.0.0 Dec 13, 2023
@anton-seaice anton-seaice merged commit 81a96d3 into COSIMA:main Dec 13, 2023
2 checks passed
@anton-seaice anton-seaice deleted the parcels_3_0_0 branch January 8, 2024 03:35
@navidcy navidcy mentioned this pull request Jul 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@navidcy navidcy navidcy approved these changes

Assignees

@anton-seaice anton-seaice

Labels
🛸 updating An existing notebook needs to be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anton-seaice @navidcy