-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Intake conversion Decomposing_kinetic_energy_into_mean_and_transient #358
Intake conversion Decomposing_kinetic_energy_into_mean_and_transient #358
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
View / edit / reply to this conversation on ReviewNB julia-neme commented on 2024-07-07T23:53:29Z Line #8. from cosima_cookbook import distributed as ccd Can this be replaced by .load() or .compute()? Otherwise this notebook still uses the soon-to-be-gone cookbook |
View / edit / reply to this conversation on ReviewNB julia-neme commented on 2024-07-07T23:53:29Z Delete? |
View / edit / reply to this conversation on ReviewNB julia-neme commented on 2024-07-07T23:53:30Z Rephrase: "Choose an experiment which has daily velocities saved for the Southern Ocean." |
View / edit / reply to this conversation on ReviewNB julia-neme commented on 2024-07-07T23:53:31Z Delete |
View / edit / reply to this conversation on ReviewNB julia-neme commented on 2024-07-07T23:53:31Z Line #5. u = darray Simplify to u = darray['u'] ? |
View / edit / reply to this conversation on ReviewNB julia-neme commented on 2024-07-07T23:53:32Z As I said above, I think when moving to intake we should stop using the cosima_cookbook |
View / edit / reply to this conversation on ReviewNB julia-neme commented on 2024-07-07T23:53:33Z This doesn't seem right - should look like the plot on the left. |
View / edit / reply to this conversation on ReviewNB julia-neme commented on 2024-07-07T23:53:33Z I don't see where KE_dz was defined? |
View / edit / reply to this conversation on ReviewNB julia-neme commented on 2024-07-07T23:53:34Z This hasn't worked either? |
View / edit / reply to this conversation on ReviewNB julia-neme commented on 2024-07-07T23:53:35Z Fix |
View / edit / reply to this conversation on ReviewNB julia-neme commented on 2024-07-07T23:53:35Z Why not start with this functions already? Seems to me a bit repetitive |
View / edit / reply to this conversation on ReviewNB julia-neme commented on 2024-07-07T23:53:36Z Line #1. @memory.cache This is probably my ignorance, but what does this line do? |
View / edit / reply to this conversation on ReviewNB julia-neme commented on 2024-07-07T23:53:37Z Line #5. ncfiles=[str(f[0].ncfile_path) for f in cc.querying._ncfiles_for_variable(expt, 'u', session) if 'ocean_daily_3d' in str(f[0].ncfile_path) ] This is still using the cookbook |
I'm sorry I don't know why all the comments where posted here. I think there are a couple of problems with this notebook:
|
Thanks for looking at this @julia-neme. I’m not sure if you realised, but @rbeucher and @max-anu who submitted these aren’t going to work on them anymore. Would you have time to implement these changes you suggest, then someone else can give it a second review? Feel free to start again from the most recent version of the notebook to convert to the intake catalog (and close this notebook) and do it yourself from scratch if that’s cleaner / easier. Or work from this one, up to you. |
…ansient.ipynb Moved to recipes
Following the discussion in issue #313, we propose converting the recipes to use Intake, given that the Cookbook is no longer supported and the ACCESS-NRI Intake catalog is now available.
A few months ago, @max-anu began working on this transition. This pull request contains the changes @max-anu made to the notebook specified in the title.