Added first version of changes to support CAN-FD. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Naresh Nayak <Naresh.Nayak@de.bosch.com>
|
This PR will look to handle #24. |
Signed-off-by: Adriaan Niess <adriaan.niess@de.bosch.com>
|
@nayakned fyi I renamed the type used for the CAN variant (classic or FD) to be consistent with the codebase |
Signed-off-by: Naresh Nayak <Naresh.Nayak@de.bosch.com>
Signed-off-by: Naresh Nayak <Naresh.Nayak@de.bosch.com>
|
Handled by new PR #29. This PR can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes should support usage of CAN-FD with an option --fd passed as a command line parameter.
However, the acf-can-talker and acf-can-listener is now slowly getting too complex with plenty of options and configuration possibilities. The code needs to be cleaned up and organized.