CommonAPI-SomeIP 3.1.11.4

COVESA · Apr 18, 2017 · c3acaae · c3acaae
1 parent 337e799
commit c3acaae
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/CHANGES b/CHANGES
@@ -1,5 +1,8 @@
 Changes
 =======
+v3.1.11.4
+- Fixed potential busy loop for mainloop applications
+
 v3.1.11.3
 - Fixed reading empty unions
 

diff --git a/src/CommonAPI/SomeIP/Watch.cpp b/src/CommonAPI/SomeIP/Watch.cpp
@@ -228,8 +228,12 @@ void Watch::pushQueue(std::shared_ptr<QueueEntry> _queueEntry) {
         }
     }
 #else
-    if(write(pipeFileDescriptors_[1], &pipeValue_, sizeof(pipeValue_)) == -1) {
-        std::perror(__func__);
+    while (write(pipeFileDescriptors_[1], &pipeValue_, sizeof(pipeValue_)) == -1) {
+        if (errno != EAGAIN && errno != EINTR) {
+            std::perror(__func__);
+            break;
+        }
+        std::this_thread::yield();
     }
 #endif
 }
@@ -253,8 +257,12 @@ void Watch::popQueue() {
     }
 #else
     int readValue = 0;
-    if(read(pipeFileDescriptors_[0], &readValue, sizeof(readValue)) == -1) {
-        std::perror(__func__);
+    while (read(pipeFileDescriptors_[0], &readValue, sizeof(readValue)) == -1) {
+        if (errno != EAGAIN && errno != EINTR) {
+            std::perror(__func__);
+            break;
+        }
+        std::this_thread::yield();
     }
 #endif