change type of autoloadPluginsVersionEcus

To potentially accelerate search Signed-off-by: Viktor Kopp <vifactor@gmail.com>
COVESA · Nov 23, 2024 · 3fc04cb · 3fc04cb
1 parent d5d9aa5
commit 3fc04cb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/mainwindow.cpp b/src/mainwindow.cpp
@@ -1986,10 +1986,10 @@ void MainWindow::reloadLogFileVersionString(QString ecuId, QString version)
 {
     // version message found in loading file, only called when loading a logfile !
 
-    if(false == autoloadPluginsVersionEcus.contains(ecuId))
+    if(!autoloadPluginsVersionEcus.contains(ecuId))
     {
       autoloadPluginsVersionStrings.append(version);
-      autoloadPluginsVersionEcus.append(ecuId);
+      autoloadPluginsVersionEcus.insert(ecuId);
 
       QFontMetrics fm = QFontMetrics(statusFileVersion->font());
       QString versionString = "Version: " + autoloadPluginsVersionStrings.join("\r\n");
@@ -4478,8 +4478,9 @@ void MainWindow::controlMessage_ReceiveControlMessage(EcuItem *ecuitem, const QD
         if(!autoloadPluginsVersionEcus.contains(msg.getEcuid()))
         {
             versionString(msg);
-            autoloadPluginsVersionEcus.append(msg.getEcuid());
+            autoloadPluginsVersionEcus.insert(msg.getEcuid());
         }
+        break;
     }
     case DLT_SERVICE_ID_GET_LOG_INFO:
     {

diff --git a/src/mainwindow.h b/src/mainwindow.h
@@ -173,7 +173,7 @@ class MainWindow : public QMainWindow
     QTableView *m_searchresultsTable;
 
     /* Autoload plugins configuration */
-    QStringList autoloadPluginsVersionEcus;
+    QSet<QString> autoloadPluginsVersionEcus;
     QStringList autoloadPluginsVersionStrings;
 
     /* String List Containing Search History */