Fix incorrect microsecond extraction in logging timestamps #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GenivivSOMEIPmaintainer : Could you please review and consider this for master branch if it looks good to you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in the logging module where the microsecond part of the timestamp was calculated incorrectly. Previously, the code used:
However, this approach incorrectly scaled the raw duration count. The correct division factor should have been
1000(not100), or better yet, the calculation can be performed in a type-safe manner usingstd::chrono::duration_cast.The updated code now correctly extracts the microsecond portion by converting the duration to microseconds.
You can see the difference of the two approaches here!
Also updated .gitignore to ignore the
.vsfolder for Visual Studio.