get_scope when argument is list #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senneberden
approved these changes
Nov 27, 2024
Collaborator
senneberden
left a comment
senneberden
left a comment
There was a problem hiding this comment.
Looks good, except that I think that function get_variables_from_constraints(constraints)should use get_scope(constraint), instead of CPMpy's get_variables, even though get_scope in turn just calls get_variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue appeared in get_scope, when the argument of a (sub)expression was a list, e.g. in sum constraints. It just ignored it and returned an empty list of vars. This PR fixes it, taking this case into account.
This PR is to be merged after the (coming) tests PR. Will also add a test for this case.