Growacq fixes on Bias construction #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some changes of previous PRs, the construction of Bias in GrowAcq is actually not optimal.
Inner algorithms were constructing the full bias in the first iteration directly, as the bias given by growacq was empty.
This is fixed, along with some more issues regarding how PQGen handled that case, of having a larger bias than the variables it considered, and how bias is constructed in problem instance.
Finally, here we also have a minor fix about emptying the bias after an inner algorithm finishes in growacq, in case redundant constraints remain there, so that it can continue to the rest of the problem.