Skip to content

Conversation

@Dimosts
Copy link
Contributor

@Dimosts Dimosts commented Oct 21, 2024

Minor (but important) fixes on GQuAcq and PQuAcq to work properly!

@Dimosts Dimosts requested a review from senneberden October 21, 2024 10:39
@Dimosts
Copy link
Contributor Author

Dimosts commented Oct 30, 2024

Needs to be merged first, before the other PRs, so that test_algorithms wont fail anymore.

@senneberden
Copy link
Collaborator

You deleted assertion assert isinstance(c, Expression), "Generalization queries first input needs to be a constraint" with a commit message saying that we actually give a relation, not an expression. Should we then not replace the assertion with another one, rather than just deleting it?

@Dimosts Dimosts requested a review from senneberden November 27, 2024 19:11
@Dimosts Dimosts merged commit e4565dd into main Nov 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants