Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Human-friendly metavariable printing #54

Open
wants to merge 7 commits into
base: refactor/qualname
Choose a base branch
from

Conversation

croyzor
Copy link
Collaborator

@croyzor croyzor commented Nov 11, 2024

Closes #3.

There are a couple of open questions here:

  1. What's a better name than nameMap? I kind of like mnemonics as we use for the user-provided names of holes
  2. What's your favourite factoring of the repeated req AskNames >>= \nm -> showRow nm pattern?

I have a hunch this could look nicer after we tackle #23.

New test case vec_length2.brat reveals an error, which I plan to fix in #38.
(This bit of code is driving me up the wall 😅)

@croyzor croyzor requested a review from acl-cqc November 11, 2024 19:04
@acl-cqc
Copy link
Collaborator

acl-cqc commented Nov 14, 2024

Naming. I reckon the current UserName should be QualName. Might as well be a newtype, rather than data, too, with the constructor also called QualName.

Then, the names here that we show to the user can be UserName...?

Failing that, hmmm, VarName? It's not good as many of our names can stand for variables. UserVarName is too long and directs me back down the QualName route. SourceCodeName, also too long - and we can't abbreviate to SrcName because we have Src's everywhere.

EDIT: VisName (yes short for visible), SurfaceName?

@croyzor croyzor changed the base branch from main to refactor/qualname November 19, 2024 11:49
@croyzor croyzor self-assigned this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prettify global type variables for error messages
2 participants