Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return replaced ops from lowering #1568

Merged
merged 1 commit into from
Oct 9, 2024
Merged

feat: return replaced ops from lowering #1568

merged 1 commit into from
Oct 9, 2024

Conversation

ss2165
Copy link
Member

@ss2165 ss2165 commented Oct 9, 2024

Finishing a todo
drive-by: whitespace trimming in yml

drive-by: whitespace trimming in yml
@ss2165 ss2165 requested a review from a team as a code owner October 9, 2024 15:04
@ss2165 ss2165 requested a review from cqc-alec October 9, 2024 15:04
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.71%. Comparing base (274a886) to head (479961b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
hugr-passes/src/lower.rs 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1568   +/-   ##
=======================================
  Coverage   85.71%   85.71%           
=======================================
  Files         132      132           
  Lines       24017    24018    +1     
  Branches    21017    21018    +1     
=======================================
+ Hits        20587    20588    +1     
  Misses       2366     2366           
  Partials     1064     1064           
Flag Coverage Δ
python 92.46% <ø> (ø)
rust 84.75% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ss2165 ss2165 added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit a725a29 Oct 9, 2024
20 of 21 checks passed
@ss2165 ss2165 deleted the ss/do-todo branch October 9, 2024 15:15
This was referenced Oct 9, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 14, 2024
## 🤖 New release
* `hugr`: 0.13.0 -> 0.13.1 (✓ API compatible changes)
* `hugr-core`: 0.10.0 -> 0.13.1 (✓ API compatible changes)
* `hugr-model`: 0.1.0 -> 0.13.1 (✓ API compatible changes)
* `hugr-passes`: 0.8.2 -> 0.13.1 (✓ API compatible changes)
* `hugr-cli`: 0.6.1 -> 0.13.1

<details><summary><i><b>Changelog</b></i></summary><p>

## `hugr`
<blockquote>

##
[0.13.1](hugr-v0.13.0...hugr-v0.13.1)
- 2024-10-14

### New Features

- return replaced ops from lowering
([#1568](#1568))
- Make `BuildHandle::num_value_outputs` public
([#1560](#1560))
- `FunctionBuilder::add_{in,out}put`
([#1570](#1570))
- Binary serialisation format for hugr-model based on capnproto.
([#1557](#1557))
</blockquote>

## `hugr-core`
<blockquote>

##
[0.13.1](hugr-core-v0.10.0...hugr-core-v0.13.1)
- 2024-10-14

### New Features

- Make `BuildHandle::num_value_outputs` public
([#1560](#1560))
- Binary serialisation format for hugr-model based on capnproto.
([#1557](#1557))
- `FunctionBuilder::add_{in,out}put`
([#1570](#1570))
</blockquote>

## `hugr-model`
<blockquote>

##
[0.13.1](hugr-model-v0.1.0...hugr-model-v0.13.1)
- 2024-10-14

### New Features

- Binary serialisation format for hugr-model based on capnproto.
([#1557](#1557))
</blockquote>

## `hugr-passes`
<blockquote>

##
[0.13.1](hugr-passes-v0.8.2...hugr-passes-v0.13.1)
- 2024-10-14

### New Features

- return replaced ops from lowering
([#1568](#1568))
</blockquote>

## `hugr-cli`
<blockquote>

## 0.6.0 (2024-09-04)

### Features

- [**breaking**] Allow registry specification in `run_dump`
([#1501](#1501))
- [**breaking**] Add `Package::validate` and return `ExtensionRegistry`
in helpers. ([#1507](#1507))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

---------

Co-authored-by: Agustín Borgna <agustin.borgna@quantinuum.com>
Co-authored-by: Agustín Borgna <121866228+aborgna-q@users.noreply.github.com>
Co-authored-by: Alec Edgington <54802828+cqc-alec@users.noreply.github.com>
This was referenced Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants