feat: to/from json for extension/package #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ss2165
force-pushed
the
ss/ext-from-json
branch
from
99f87b0
to
45f9df5
Compare
aborgna-q
approved these changes
Oct 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1575 +/- ##
==========================================
+ Coverage 85.69% 85.70% +0.01%
==========================================
Files 135 135
Lines 24563 24574 +11
Branches 21512 21512
==========================================
+ Hits 21050 21062 +12
+ Misses 2415 2414 -1
Partials 1098 1098
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 14, 2024
🤖 I have created a release *beep* *boop* --- ## [0.9.0](hugr-py-v0.8.1...hugr-py-v0.9.0) (2024-10-14) ### ⚠ BREAKING CHANGES * `Package` moved to new `hugr.package` module * The `length` op in the std `collections` extensions now also returns the list. ### Features * `instantiate` method for `OpDef` ([#1576](#1576)) ([36548ab](36548ab)), closes [#1512](#1512) * define wrappers around package that point to internals ([#1573](#1573)) ([f74dbf3](f74dbf3)) * to/from json for extension/package ([#1575](#1575)) ([f8bf61a](f8bf61a)), closes [#1523](#1523) ### Bug Fixes * Make list length op give back the list ([#1547](#1547)) ([cf31698](cf31698)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Agustín Borgna <agustin.borgna@quantinuum.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1523