Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expand SimpleReplacement API #1920

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

lmondada
Copy link
Contributor

@lmondada lmondada commented Feb 13, 2025

I would like to reuse the replacement logic in tket2, so I've taken the opportunity to expand the API of SimpleReplacement and refactor things a bit.

@lmondada lmondada requested a review from a team as a code owner February 13, 2025 12:35
@lmondada lmondada requested a review from croyzor February 13, 2025 12:35
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 80.98592% with 27 lines in your changes missing coverage. Please review.

Project coverage is 83.75%. Comparing base (242e12f) to head (6bddd76).

Files with missing lines Patch % Lines
hugr-core/src/hugr/rewrite/simple_replace.rs 81.25% 23 Missing and 1 partial ⚠️
hugr-core/src/hugr/rewrite/port_types.rs 78.57% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1920      +/-   ##
==========================================
- Coverage   83.78%   83.75%   -0.04%     
==========================================
  Files         196      197       +1     
  Lines       37470    37537      +67     
  Branches    34283    34350      +67     
==========================================
+ Hits        31396    31438      +42     
- Misses       4296     4320      +24     
- Partials     1778     1779       +1     
Flag Coverage Δ
python 92.34% <ø> (ø)
rust 82.95% <80.98%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant