Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/tex #78

Merged
merged 5 commits into from
Nov 7, 2024
Merged

Bugfix/tex #78

merged 5 commits into from
Nov 7, 2024

Conversation

DNA386
Copy link
Collaborator

@DNA386 DNA386 commented Nov 6, 2024

actual fix for #76 (comment)

Tex rendering is now deferred and fully controlled by mathjax-content component to avoid leakage.
This can be demoed by first building the code and serving it locally:

npm run parser
npm run build-lib
serve .

Then navigate to http://localhost:3000/test/test_mjx_rendering. It should look like this:
Screenshot 2024-11-06 at 16 12 34

(This replicates the initial html generated by pytket)

Note that this issue won't be noticeable in storybook as mathjax is usually loaded before the circuit data as it is all done dynamically.

@DNA386 DNA386 requested a review from CalMacCQ November 6, 2024 16:43
Copy link

@CalMacCQ CalMacCQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The html thats served locally looks good.

Happy to help with further testing if need be.

@DNA386 DNA386 merged commit 0c9ebe7 into main Nov 7, 2024
1 check passed
@DNA386 DNA386 deleted the bugfix/tex branch November 7, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants