Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Multi-shot sampling from GeneralState #129

Merged
merged 81 commits into from
Jun 27, 2024
Merged

[feature] Multi-shot sampling from GeneralState #129

merged 81 commits into from
Jun 27, 2024

Conversation

PabloAndresCQ
Copy link
Collaborator

@PabloAndresCQ PabloAndresCQ commented Jun 13, 2024 •
edited
Loading

Description

  • Adds support for sample to obtain multiple shots from end-of-circuit measurements using the GeneralState framework.
  • Additionally, removes the need for replacing implicit wire swaps with SWAP gates.

Related issues

First step towards #121.

Checklist

  • I have run the tests on a device with GPUs.
  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

@yapolyak
Moved modules dealing with exact TN circuit representation to s separ…
034af98 
…ate folder.
@yapolyak
Started drafting TensorNetworkState constructor (converter).
0c05f1f
@yapolyak
Finished drafting TensorNetworkState constructor (converter).
00c5b21
@yapolyak
Subtle changes to CuTensorNetHandle (untested).
acdf958
@yapolyak
Some refurbishment. Renamed TensorNetworkState into GeneralState.…
657740a 
… Added `GeneralState.update_gates()` method.
@yapolyak
Merged develop in.
73a0e20
@yapolyak
Refactoring folder name: exact -> general_state
94d7019
@yapolyak
Started drafting GeneralOperator.
3516303
@yapolyak
Finished drafting GeneralOperator class.
6695940
@yapolyak
Started drafting GeneralExpectationValue class.
2df1abb
@yapolyak
Finished drafting GeneralExpectationValue class.
c670749
@yapolyak
Added .configure(), .prepare() and drafted compute() in `Genera…
bce7c95 
…lState`.
@yapolyak
Imports additions/refactor.
8a6dccf
@yapolyak
Fix in cutn attributes.
b1d7295
@yapolyak
Fix a bug in GeneralState.configure().
c196e4d
@yapolyak
Handle device aliasing bug fix.
0faf65a
@yapolyak
Corrected cutn.state_compute() arguments list.
e4defcd
@yapolyak
Fixed cutn.state_compute().
4cdb622
@yapolyak
Factored our configure and prepare steps for GeneralExpectationValue.
9e64915
@yapolyak
Fixes to GeneralState after debugging.
c5df6df
@yapolyak
Fixes to GeneralOperator after debugging.
5cd6936
@yapolyak
Fixes to GeneralExpectationValue after debugging.
fb34305
@yapolyak
Added state and operator properties to corresponding classes.
1eb091f
@yapolyak
Enabled chaining of some methods.
71aff80
@yapolyak
GeneralOperator now accepts QubitPauliOperator as parameter.
627d475
@yapolyak
Added statevector test.
106b87d
@yapolyak
Added gate unitary transpose to account for the way cuTN stores tensors
3d12261
@yapolyak
Added overlap test.
cf30aa3
@yapolyak
Added a toffoli box with implicit swaps test and corresponding fix to…
3d477ad 
… `GeneralState`.
@yapolyak
Added test_generalised_toffoli_box.
5a0f418
@PabloAndresCQ PabloAndresCQ marked this pull request as ready for review June 13, 2024 14:55
@PabloAndresCQ PabloAndresCQ changed the title Feature/general sampler [feature] Multi-shot sampling from GeneralState Jun 13, 2024
@PabloAndresCQ PabloAndresCQ mentioned this pull request Jun 25, 2024
Merged
6 tasks
Base automatically changed from feature/exact_state to main June 26, 2024 14:33
jake-arkinstall
jake-arkinstall previously approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@jake-arkinstall jake-arkinstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR cleans up the interface nicely and adds an extremely useful method. The code is clean and merging does not introduce any issues to testing or performance on my system. Merging is a no-brainer to me!

@PabloAndresCQ PabloAndresCQ merged commit ea4bf70 into main Jun 27, 2024
8 checks passed
@PabloAndresCQ PabloAndresCQ deleted the feature/general_sampler branch June 27, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jake-arkinstall jake-arkinstall jake-arkinstall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PabloAndresCQ @jake-arkinstall @yapolyak