-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update registerhandling to use i1* pointer #61
Conversation
e6ec0b1
to
31a0ede
Compare
31a0ede
to
ca50e79
Compare
The discussed changes for the classical register handling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we talked about settling on better names for the API functions. I have left some suggestions. Perhaps it makes sense to list them out all together:
i1* create_creg (i64 size )
void set_creg_to_int (i1* creg, i64 value )
i64 get_int_from_creg(i1* creg )
void set_creg_bit (i1* creg, i64 index, i1 value)
i1 get_creg_bit (i1* creg, i64 index )
Note that in the backend compiler, a notion of creg
is prevalent so perhaps it makes sense to also use it for this API.
I am open to hear about other suggestions. cc: @peter-campora
I have done a search and replace as suggested, I have replaced that in all of the ll files for the tests as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the careful changes!
No description provided.