fix: update websockets dependency to be compatible with pytket-quantinuum #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nuum pytket-quantinuum updated in version 0.38.1 (October 2024) CQCL/pytket-quantinuum@6828486
vanyae-cqc
approved these changes
Nov 4, 2024
|
the integration test failure isn't this PR, I fix the issue here: #92 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytket-quantinuum updated in version 0.38.1 (October 2024)
See CQCL/pytket-quantinuum@6828486
Our only dependency is qnexus itself, and we only use the imported code in a very "vanilla" fashion, so I've kept
>11for maximum compatibility with other libraries that might be installed alongsideqnexus.What I'm not sure about is whether to just remove the upper bound on the constraint and go with an open-ended
>11.0(similar to pytket-quantinuum which now has>=13.1). For correctness I've left it in, because websockets might release a breaking change in their version 14.x. But we could discuss.