Fix edges in state machine when dealing with optionals #772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For expressions in the
ORDER
section of the form(Op1?, Op2)*
, the state machine is missing an edge. Currently, there are tree states0
,1
and2
with the edges0 --Op1--> 1
,1 --Op2--> 2
,0 --Op2--> 2
and2 --Op1--> 1
. This forces to useOp1
after usingOp2
and being in state2
. However, sinceOp1
is optional, there is a missing edge2 --Op2--> 2
that models usingOp2
mulitple times. This edge is added with this PR.Close #295