Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edges in state machine when dealing with optionals #772

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

smeyer198
Copy link
Contributor

For expressions in the ORDER section of the form (Op1?, Op2)*, the state machine is missing an edge. Currently, there are tree states 0, 1 and 2 with the edges 0 --Op1--> 1, 1 --Op2--> 2, 0 --Op2--> 2 and 2 --Op1--> 1. This forces to use Op1 after using Op2 and being in state 2. However, since Op1 is optional, there is a missing edge 2 --Op2--> 2 that models using Op2 mulitple times. This edge is added with this PR.

Close #295

@schlichtig schlichtig added this pull request to the merge queue Nov 29, 2024
Merged via the queue into develop with commit 67ad228 Nov 29, 2024
7 checks passed
@schlichtig schlichtig deleted the fix/issue295 branch November 29, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False Negatives reported by CogniCrypt_TESTGEN
2 participants