Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Login and Registration Pages #32

Merged
merged 26 commits into from
Sep 26, 2024
Merged

Add Login and Registration Pages #32

merged 26 commits into from
Sep 26, 2024

Conversation

McNaBry
Copy link

@McNaBry McNaBry commented Sep 22, 2024 •
edited
Loading

Add basic UI for login and registration page. Pages are not linked to the user service.

  • Add basic UI for login, allows users to enter their username and password
  • Add basic UI for registration, allows users to enter their desired username, email and password.
  • Add password strength validation
  • Add validation to restrict password to an allowed set of characters

@McNaBry McNaBry force-pushed the login-registration-page branch from 93d115b to a4284d1 Compare September 22, 2024 13:22
@McNaBry McNaBry linked an issue Sep 22, 2024 that may be closed by this pull request
Add Login / Registration Page #7
Closed
@McNaBry McNaBry force-pushed the login-registration-page branch from a4284d1 to 1728ef6 Compare September 23, 2024 13:05
@McNaBry McNaBry requested review from samuelim01 and removed request for limcaaarl September 25, 2024 16:10
samuelim01
samuelim01 approved these changes Sep 25, 2024
View reviewed changes
Copy link

@samuelim01 samuelim01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@McNaBry McNaBry requested a review from samuelim01 September 26, 2024 03:18
@McNaBry McNaBry force-pushed the login-registration-page branch from df608f9 to 21c45af Compare September 26, 2024 06:23
@McNaBry McNaBry force-pushed the login-registration-page branch from fee3be1 to 641b854 Compare September 26, 2024 14:05
samuelim01
samuelim01 approved these changes Sep 26, 2024
View reviewed changes
Copy link

@samuelim01 samuelim01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🆗

@samuelim01 samuelim01 merged commit f2df810 into main Sep 26, 2024
2 checks passed
@samuelim01 samuelim01 deleted the login-registration-page branch September 29, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelim01 samuelim01

@LimZiJia LimZiJia

Assignees
No one assigned
Labels
frontend priority.Medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Login / Registration Page
2 participants
@McNaBry @samuelim01