Skip to content

Question Service Minor Update #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 27, 2024

Conversation

KhoonSun47
Copy link

@KhoonSun47 KhoonSun47 commented Sep 27, 2024

Question Service Minor Update

Update details on README and standardise all handling of error and success to return message

Checklist

  • Updated README
  • Updated Error & Success Handling

KhoonSun47 and others added 6 commits September 15, 2024 22:34
…project-g03

* 'main' of https://github.com/KhoonSun47/cs3219-ay2425s1-project-g03:
  PR template (CS3219-AY2425S1#3)
  Remove .idea from tracking and update .gitignore
  Add .idea to .gitignore and remove from Git tracking
  Added .idea to .gitignore
  Use ESlint for indentation
  Update README.md and functionality of Endpoints:
  Minor Fixes on Question Service
  Update README.md
  Fix EsLint Issues
  Update README.md and MongoDB settings:
  Update README.md and Endpoints:
  Update README.md and endpoint
  Update README.md for Question Service
  feat: Update and add new endpoints for question service
  Add new get endpoint and update models
  Add node_modules to .gitignore
  Update README.md
  Update README.md for Question Service

# Conflicts:
#	README.md
-README: Update details on addQuestions
-questionController.ts: Update handling error
-helper.ts: Update handling error
Copy link

@limcaaarl limcaaarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! All the errors/bad requests messages can be retrieved consistently now.

@limcaaarl limcaaarl merged commit 154b802 into CS3219-AY2425S1:main Sep 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants