-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Init user service #39
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Got user service to work in docker. It can only interface with an atlas cloud server currently.
User-service in docker can only communicate with an atlas mongodb server.
Some files should have been committed in the previous commit. They are mostly to do with the dockerisation process. The merge with main might have messed with it.
Somehow .gitignore was not commited with the last commit
Apparently bcrypt library cannot run on Docker's architecture. Change bcrypt to bcryptjs for compatibility.
Not connected to the login interface yet. Commiting to make a clean Pr.
* Remove orphan history file * Move `index.js` and `server.js` to the correct directory * Reduce use of port
samuelim01
approved these changes
Sep 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is in this PR
This is just the basic user-service. It is dockerised, can connect to an atlas cluster and the endpoints are working
What is not in this PR
Documentation, tests and connection to the login page.
Checklist
Connecting to server
This user-service is run on my own free atlas mongodb server. To connect to db, make an atlas cluster. It will show on the dashboard like this:
Click on connect > drivers > 3. Add your connection string into your application code
Copy paste as
USER_SERVICE_CLOUD_URI
in the.env
file with the password you set earlier.