-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve README and docker compose files #43
Conversation
* Split `docker-compose.yml` into `compose.yml` and `compose.dev.yml` * Ensure all containers restart * Unmount volumes for base `compose.yml` * Publish backend service ports only for `compose.dev.yml` * Configure backend services to have both "start" and "dev" scripts
Just tested using |
* Ensure backend services can communicate * Remove useless networks * Due to the lack of API gateway, all backend services currently need to be exposed directly for now.
good catch, there was a very glaring error in the docker compose file 😞 currently all backend services needs their ports exposed because the frontend client makes calls directly from the user's browser instead of through the frontend server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* main: Improve README and docker compose files (CS3219-AY2425S1#43) Update README and questionController.ts (CS3219-AY2425S1#42)
Description
README.md
for development start up.node_modules/
folders that may arise when mounted for hot reloading in development environments.Checklist
Screenshots (if applicable)