Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for #77 #91

Merged
merged 7 commits into from
Nov 13, 2024
Merged

Bug fix for #77 #91

merged 7 commits into from
Nov 13, 2024

Conversation

limcaaarl
Copy link

Fixes #77

  • Users will now be warned when their tokens are about to expire
  • Users will be logged out upon token expiration

image

- Users will now be warned if their tokens are about to expire
- Users will be logged out upon token expiration
@limcaaarl limcaaarl added the bug Something isn't working label Nov 12, 2024
@limcaaarl limcaaarl self-assigned this Nov 12, 2024
Copy link

@samuelim01 samuelim01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended, but not sure we need an interval

frontend/src/_services/authentication.service.ts Outdated Show resolved Hide resolved
@samuelim01
Copy link

@limcaaarl I pushed some changes, if it's okay you can merge!

@limcaaarl
Copy link
Author

@limcaaarl I pushed some changes, if it's okay you can merge!

I'm getting error with the new commits. This happens when I try to register/login as per normal.

image

@limcaaarl
Copy link
Author

@limcaaarl I pushed some changes, if it's okay you can merge!

I'm getting error with the new commits. This happens when I try to register/login as per normal.

image

wait nvm your latest one fixed it as I was commenting 🤣🤣

@limcaaarl
Copy link
Author

@samuelim01 LGTM, working as intended

@samuelim01 samuelim01 merged commit de92e85 into main Nov 13, 2024
6 checks passed
@samuelim01 samuelim01 deleted the fix-jwt branch November 13, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complications of JWT token
2 participants