Skip to content

Fix sidebar bug #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix sidebar bug #96

wants to merge 1 commit into from

Conversation

limcaaarl
Copy link

Description

  • Fixed sidebar bug where it goes underneath the navbar when repeatedly opened and closed.

@limcaaarl limcaaarl added the bug Something isn't working label Nov 13, 2024
@limcaaarl limcaaarl self-assigned this Nov 13, 2024
@limcaaarl limcaaarl changed the title Remove transition option from sidebar Fix sidebar bug Nov 13, 2024
[blockScroll]="true"
styleClass="w-10 md:w-4"
transitionOptions="300ms cubic-bezier(0, 0, 0.2, 1)">
<p-sidebar [(visible)]="isPanelVisible" position="right" [blockScroll]="true" styleClass="w-10 md:w-4">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p-sidebar [(visible)]="isPanelVisible" position="right" [blockScroll]="true" styleClass="w-10 md:w-4">
<p-sidebar [(visible)]="isPanelVisible" position="right" (onHide)="closePanel()" [blockScroll]="true" styleClass="w-10 md:w-4">

@McNaBry
Copy link

McNaBry commented Nov 13, 2024

Fixed by #99

@McNaBry McNaBry closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants