Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc Frontend Improvements #53

Closed
wants to merge 8 commits into from
Closed

Misc Frontend Improvements #53

wants to merge 8 commits into from

Conversation

chiaryan
Copy link

@chiaryan chiaryan commented Oct 25, 2024

Changes
Fixes to matchmaking timer display

  • Timer should tick up when searching for match
    • Match Found modal should display time when match was found
      • Joined Match Modal timer should tick up continuously
    • Match Cancelled timer should display time when match was cancelled
    • Match Not Found timer should displayed time when match timed out (both frontend and backed side)

Lift Form state to be a part of match modal component

  • Change matchmaking parameters to use antdesign Form Component
  • Readded Retry button to start matchmaking with old settings

Removed 'Cancel' button for Found Match Modal

@chiaryan chiaryan marked this pull request as ready for review October 25, 2024 09:25
@chiaryan chiaryan closed this Oct 30, 2024
@chiaryan chiaryan mentioned this pull request Oct 30, 2024
@chiaryan chiaryan deleted the frontend-changes branch November 5, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant