Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N11 - unit tests #65

Merged
merged 30 commits into from
Nov 4, 2024
Merged

N11 - unit tests #65

merged 30 commits into from
Nov 4, 2024

Conversation

chiaryan
Copy link

@chiaryan chiaryan commented Nov 3, 2024

Setup testing workflows for frontend and question-service

Unit tests for:

  • frontend: Question Api
  • question-service: DecodeJSON and ReadQuestion

tituschewxj
tituschewxj approved these changes Nov 4, 2024
View reviewed changes
Copy link

@tituschewxj tituschewxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for implementing the tests. A suggestion would be to consider having a separate Firestore instance for testing.

.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
@chiaryan chiaryan merged commit 0d2a3bc into staging Nov 4, 2024
3 checks passed
@chiaryan chiaryan deleted the n11-unit-tests branch November 4, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tituschewxj tituschewxj tituschewxj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chiaryan @tituschewxj