Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional Integration tests for question service #81

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Additional Integration tests for question service #81

merged 1 commit into from
Nov 13, 2024

Conversation

chiaryan
Copy link

Add tests in these files:

  • create_test.go
  • update_test.go
  • delete_test.go
  • Also separated out common test utilities in common_test.go

@chiaryan chiaryan changed the base branch from solomon/fix-code-saved-message-appearing-on-end-session to staging November 13, 2024 06:23
@chiaryan chiaryan closed this Nov 13, 2024
@chiaryan chiaryan reopened this Nov 13, 2024
tituschewxj
tituschewxj approved these changes Nov 13, 2024
View reviewed changes
Copy link

@tituschewxj tituschewxj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tituschewxj tituschewxj merged commit abf4605 into staging Nov 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tituschewxj tituschewxj tituschewxj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chiaryan @tituschewxj