Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt at N4 to add JavaScript into Code Editor #85

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Conversation

bensohh
Copy link

@bensohh bensohh commented Nov 13, 2024

  • Attempt at N4 which works with a success notification for both users when code language changes
  • Add localStorage.clear() method back for logging out
  • Remove and replaced previous implementation of the autolanguage

TODO:

  • Link the frontend method to change the executing container based on selected editor language
    (p.s: Note that the current editor's language is stored in localStorage with key value "editor-language" so you can access there or via the selectedLanguage useState within the CollaborativeEditor component)
    @tituschewxj @solomonng2001 @UnwilledTangent

@bensohh bensohh self-assigned this Nov 13, 2024
Copy link

@UnwilledTangent UnwilledTangent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@UnwilledTangent UnwilledTangent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
wait, are we able to submit code? with reference to the picture

Copy link

@UnwilledTangent UnwilledTangent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bensohh bensohh merged commit bd95eb0 into staging Nov 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants