Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

36 activate and deactivte recommendation #49

Merged
merged 6 commits into from
Nov 21, 2023

Conversation

WYB929
Copy link
Contributor

@WYB929 WYB929 commented Nov 21, 2023

No description provided.

@WYB929 WYB929 requested a review from oyster14 November 21, 2023 22:32
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1619b2d) 97.01% compared to head (7c946e7) 97.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   97.01%   97.27%   +0.26%     
==========================================
  Files           8        8              
  Lines         368      404      +36     
==========================================
+ Hits          357      393      +36     
  Misses         11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@oyster14 oyster14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great jobs on activation, deactivation, and their tdd test cases

@oyster14 oyster14 merged commit a1b9ce1 into master Nov 21, 2023
4 checks passed
@oyster14 oyster14 deleted the 36_activate_and_deactivte_recommendation branch November 21, 2023 23:10
@WYB929 WYB929 self-assigned this Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants