Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date picker to show arrows #4

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

janiemi
Copy link

@janiemi janiemi commented Jul 8, 2024

This is a cherry picked from Språkbanken’s Korp frontend code to fix the date picker to show arrows when selecting a date interval, overloading glyphicon with fa for datepicker (see spraakbanken#266).

This should be merged along with merging the configuration branch config/t-fix-date-interval-chooser to config/master to fix the date interval chooser.

styles.scss: Overload "glyphicon" with "fa" for datepicker

(cherry picked from commit 36e828f)
@janiemi janiemi requested a review from aajarven July 8, 2024 05:25
@janiemi
Copy link
Author

janiemi commented Jul 10, 2024

@aajarven, thanks for reviewing. Could you please also either merge this to master or give me the rights to do that, as I no longer seem to be allowed to do that. No hurry, though, as I think it would be good to have a Korp test instance in which someone could review in practice this and the associated configuration change in branch config/t-fix-date-interval-chooser, before taking the changes into production.

@mmatthiesencsc mmatthiesencsc merged commit 21ba8a2 into master Oct 1, 2024
1 of 2 checks passed
@mmatthiesencsc mmatthiesencsc deleted the t-fix-datepicker-arrows branch October 1, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants