PET_HAMON fix for negative PET and bug fix to PCT_PDIFF diagnostic#60
Merged
rchlumsk merged 2 commits intoCSHS-CWRA:mainfrom Sep 5, 2025
rchlumsk:main
Merged
PET_HAMON fix for negative PET and bug fix to PCT_PDIFF diagnostic#60rchlumsk merged 2 commits intoCSHS-CWRA:mainfrom rchlumsk:main
rchlumsk merged 2 commits intoCSHS-CWRA:mainfrom
rchlumsk:main
Conversation
Member
rchlumsk
commented
Sep 5, 2025
rchlumsk
commented
- adds max(x,0) for PET_HAMON method to fix negative PET from being introduced
- fixes bug in PCT_PDIFF diagnostic calculaton with appropriate bracketing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.