Skip to content

Conversation

@Dragonfly911117
Copy link
Contributor

too lazy to fix blank pages

see online view if u don't feel like downloading yourself

Dragonfly911117 and others added 3 commits June 11, 2025 14:50
Co-authored-by: vincent <hankggg2003xd@gmail.com>
Co-authored-by: UG <ug00257793@gmail.com>
Co-authored-by: garry <garry80633@gmail.com>
@Dragonfly911117 Dragonfly911117 added the documentation Improvements or additions to documentation label Jun 12, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates project documentation for Homework 7, tweaks the PlantUML diagram, and adds new unit tests for the UML diagram backend.

  • Bumped homework number in the LaTeX title page to 7
  • Modified PlantUML file (dm.iuml): adjusted directives and link labels
  • Introduced several new tests in umldiagram_test.go

Reviewed Changes

Copilot reviewed 40 out of 40 changed files in this pull request and generated no comments.

File Description
docs/report/configurations.tex Updated "Homework #6" to "Homework #7" on the title page
docs/graphs/dm.iuml Changed hide/enduml directives, removed emojis, and link text
app/backend/umldiagram/umldiagram_test.go Added multiple test cases (some duplicated function definitions)
Comments suppressed due to low confidence (9)

docs/graphs/dm.iuml:103

  • Typo in Asscotiates; please correct it to Associates.
Gadget "1...2" -- "*" Association : Asscotiates

docs/graphs/dm.iuml:94

  • Typo in UMLroject; it should be UMLProject.
A UMLroject can has multi UMLDiagrams.

docs/graphs/dm.iuml:130

  • Typo in conneection; please correct it to connection.
For conneection timeout.

docs/graphs/dm.iuml:3

  • The apostrophe turns the hide attribute directive into a comment, so attributes won't actually hide. Remove the leading apostrophe to apply the directive.
'hide attribute

docs/graphs/dm.iuml:90

  • The apostrophe prefixes the @enduml tag as a comment, preventing the diagram from closing correctly. Remove the apostrophe so the tag takes effect.
'@endtuml

app/backend/umldiagram/umldiagram_test.go:1893

  • Duplicate test function TestBaseCommandTimestamps found; Go test functions must have unique names. Remove or rename this duplicate.
func TestBaseCommandTimestamps(t *testing.T) {

app/backend/umldiagram/umldiagram_test.go:1910

  • Duplicate test function TestSelectAllCommand found; Go test functions must have unique names. Remove or rename this duplicate.
func TestSelectAllCommand(t *testing.T) {

app/backend/umldiagram/umldiagram_test.go:1960

  • Duplicate test function TestHasUnsavedChanges found; Go test functions must have unique names. Remove or rename this duplicate.
func TestHasUnsavedChanges(t *testing.T) {

app/backend/umldiagram/umldiagram_test.go:2033

  • Duplicate test function TestCollectGadgetsAndAssociations found multiple times; tests must have unique names. Consolidate or rename duplicates.
func TestCollectGadgetsAndAssociations(t *testing.T) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants