Adds a handful of svg props #240
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frvge
reviewed
Nov 11, 2017
| @@ -172,6 +174,8 @@ var Properties = module.exports = { | |||
| "cue-after" : 1, | |||
| "cue-before" : 1, | |||
| "cursor" : 1, | |||
| "cx" : "<coordinate>", | |||
There was a problem hiding this comment.
The coordinate would need to be added to ValidationTypes.js . I'll see if I can do that. You're of course also welcome to add it, and a test.
There was a problem hiding this comment.
Thanks @frvge,
MDN states the <coordinate> content type's syntax is the same as <length>. I went ahead and added it to be explicit, but could have simply switched out <coordinate> for <length> in Properties.js. Let me know if you have a preference. Otherwise, I added a test for the <coordinate> type.
frvge
requested changes
Nov 22, 2017
| @@ -0,0 +1,3 @@ | |||
| { | |||
There was a problem hiding this comment.
I think this file can be removed, or added to a gitignore file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a handful of SVG attributes to the props definition list using the MDN SVG Attribute reference. This PR adds the following attrs:
calcMode,clipPathUnits,cx,cy, andr.