KFSPTS-30975 restrict who can edit the processor net id field (#1560)

CU-CommunityApps · Feb 21, 2024 · 5a2fc65 · 5a2fc65
1 parent fda8fd2
commit 5a2fc65
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 1 deletion.
diff --git a/src/main/java/edu/cornell/kfs/module/purap/CUPurapConstants.java b/src/main/java/edu/cornell/kfs/module/purap/CUPurapConstants.java
@@ -125,6 +125,7 @@ public static final class IWantPresentationModes {
     //while also ensuring the existing functionality for all other edit modes was retained. 
     public static final String I_WANT_DOC_MULTIPLE_PAGE_IS_ALLOWED = "multiplePageIsAllowed";
     public static final String I_WANT_DOC_FULL_PAGE_IS_ALLOWED = "fullPageIsAllowed";
+    public static final String I_WANT_DOC_EDIT_PROC_NET_ID = "editProcessorNetId";
 
     public static final String IWNT_DOC_TYPE = "IWNT";
     public static final String IWNT_STEP_PARAMETER = "step";

diff --git a/.../cornell/kfs/module/purap/document/authorization/IWantDocumentPresentationController.java b/.../cornell/kfs/module/purap/document/authorization/IWantDocumentPresentationController.java
@@ -143,6 +143,8 @@ public Set<String> getEditModes(Document document) {
             editModes.add(CUPurapConstants.I_WANT_DOC_MULTIPLE_PAGE_IS_ALLOWED);
             editModes.add(CUPurapConstants.I_WANT_DOC_FULL_PAGE_IS_ALLOWED);
         }
+
+        editModes.add(CUPurapConstants.I_WANT_DOC_EDIT_PROC_NET_ID);
 
         return editModes;
     }

diff --git a/src/main/java/edu/cornell/kfs/module/purap/document/web/struts/IWantDocumentForm.java b/src/main/java/edu/cornell/kfs/module/purap/document/web/struts/IWantDocumentForm.java
@@ -11,6 +11,7 @@
 import org.kuali.kfs.sys.document.web.struts.FinancialSystemTransactionalDocumentFormBase;
 import org.kuali.kfs.core.api.config.property.ConfigContext;
 import org.kuali.kfs.core.api.util.KeyValue;
+import org.kuali.kfs.kew.api.WorkflowDocument;
 
 import java.util.ArrayList;
 import java.util.HashMap;
@@ -366,6 +367,11 @@ protected ExtraButton createCreateDVButton() {
         clearButton.setExtraButtonParams("_blank");
         return clearButton;
     }
+
+    public boolean isDocEnroute() {
+        final WorkflowDocument workflowDocument = getDocument().getDocumentHeader().getWorkflowDocument();
+        return ObjectUtils.isNotNull(workflowDocument) && workflowDocument.isEnroute();
+    }
 
     public String getPresentationMode() {
         return presentationMode;

diff --git a/src/main/webapp/WEB-INF/tags/module/purap/iWantDocumentOverview.tag b/src/main/webapp/WEB-INF/tags/module/purap/iWantDocumentOverview.tag
@@ -5,6 +5,9 @@
 <c:set var="docHeaderAttributes" value="${DataDictionary.DocumentHeader.attributes}"/>
 <c:set var="iWantDocAttributes" value="${DataDictionary.IWantDocument.attributes}"/>
 <c:set var="fullEntryMode" value="${KualiForm.documentActions[KRADConstants.KUALI_ACTION_CAN_EDIT]}"/>
+<c:set var="canEditProcessorNetId" value="${(not empty KualiForm.editingMode['editProcessorNetId'])}" scope="request"/>
+<c:set var="docEnroute" value="${KualiForm.docEnroute}"/>
+<c:set var="processorNetIdReadOnly" value="${!fullEntryMode || !canEditProcessorNetId || !docEnroute}" scope="request"/>
 
 <div class="tab-container" align="center">
     <html:hidden property="document.documentHeader.documentNumber"/>
@@ -92,7 +95,7 @@
                           universalId=""
                           userNameFieldName="document.processorName"
                           userName="${KualiForm.document.processorName}"
-                          readOnly="${not fullEntryMode}"
+                          readOnly="${processorNetIdReadOnly}"
                           fieldConversions="principalName:document.processorNetId,name:document.processorName"
                           hasErrors="${hasErrors}"
                           onblur="loadProcessorInfo('document.processorNetId', 'document.processorName')"/>