KFSPTS-31154 CheckRecon Set Active Flag true (#1571)

CU-CommunityApps · Mar 5, 2024 · c6b4e9f · c6b4e9f
1 parent 1f7c57a
commit c6b4e9f
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 1 deletion.
diff --git a/src/main/java/com/rsmart/kuali/kfs/cr/batch/CheckReconciliationImportStep.java b/src/main/java/com/rsmart/kuali/kfs/cr/batch/CheckReconciliationImportStep.java
@@ -893,6 +893,7 @@ private CheckReconciliation setCheckReconciliationAttributes(Map<Integer, String
         issueDate = dateParser.apply(issueDateRawValue);
 
         CheckReconciliation cr = new CheckReconciliation();
+        cr.setActive(true);
         cr.setAmount(amount);
         cr.setCheckDate(new java.sql.Date(issueDate.getTime()));
         cr.setCheckNumber(new KualiInteger(checkNumber));

diff --git a/src/main/java/com/rsmart/kuali/kfs/cr/businessobject/CheckReconciliation.java b/src/main/java/com/rsmart/kuali/kfs/cr/businessobject/CheckReconciliation.java
@@ -61,7 +61,7 @@ public class CheckReconciliation extends PersistableBusinessObjectBase implement
 
     private Bank bank;
 
-    private boolean active;
+    private boolean active = true;
 
     /**
      * Constructs a CheckBase business object.

diff --git a/src/main/java/com/rsmart/kuali/kfs/cr/dataaccess/impl/CheckReconciliationDaoOjb.java b/src/main/java/com/rsmart/kuali/kfs/cr/dataaccess/impl/CheckReconciliationDaoOjb.java
@@ -117,6 +117,7 @@ public Collection<CheckReconciliation> getNewCheckReconciliations(Collection<Ban
 
             while(rs.next()) {
                 cr = new CheckReconciliation();
+                cr.setActive(true);
                 cr.setCheckNumber(new KualiInteger(rs.getInt(1)));
                 cr.setCheckDate(new java.sql.Date(rs.getDate(2).getTime()));  //This is last status change date.
                 cr.setAmount(new KualiDecimal(rs.getDouble(3)));

diff --git a/src/test/java/com/rsmart/kuali/kfs/cr/batch/CheckReconciliationImportStepTest.java b/src/test/java/com/rsmart/kuali/kfs/cr/batch/CheckReconciliationImportStepTest.java
@@ -551,6 +551,7 @@ private void assertCheckReconciliationImportHadExpectedUpdates(
             assertEquals(checkReconFixture.newCheckStatus, checkRecon.getStatus(), "Wrong check status");
             assertEquals(checkReconFixture.getParsedStatusChangeDate(), checkRecon.getStatusChangeDate(),
                     "Wrong status change date");
+            assertTrue(checkRecon.isActive());
         }
     }
 

diff --git a/src/test/java/com/rsmart/kuali/kfs/cr/batch/fixture/CheckReconciliationFixture.java b/src/test/java/com/rsmart/kuali/kfs/cr/batch/fixture/CheckReconciliationFixture.java
@@ -100,6 +100,7 @@ public CheckReconciliation toCheckReconciliationUsingCurrentStatus() {
     private CheckReconciliation toCheckReconciliation() {
         CheckReconciliation checkReconciliation = new CheckReconciliation();
         checkReconciliation.setId(ordinal());
+        checkReconciliation.setActive(true);
         checkReconciliation.setBankCode(bankCode);
         checkReconciliation.setBankAccountNumber(getExpectedBankAccountNumber());
         checkReconciliation.setCheckNumber(checkNumber);

diff --git a/src/test/java/com/rsmart/kuali/kfs/cr/document/CheckReconciliationMaintainableImplTest.java b/src/test/java/com/rsmart/kuali/kfs/cr/document/CheckReconciliationMaintainableImplTest.java
@@ -68,6 +68,7 @@ private MaintenanceDocument prepareMaintenanceDocument(String checkNumberString,
         document.setDocumentHeader(dh);
 
         CheckReconciliation newCr = new CheckReconciliation();
+        newCr.setActive(true);
         KualiInteger checkNumber = new KualiInteger(checkNumberString);
         newCr.setCheckNumber(checkNumber);