Project update 2 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwalkes
commented
Apr 22, 2019
|
|
||
| /* perform a factory reset by erasing PS storage. This removes all the keys and other settings | ||
| that have been configured for this node */ | ||
| gecko_cmd_flash_ps_erase_all(); |
There was a problem hiding this comment.
@PuneetBansal missing error checks.
dwalkes
commented
Apr 22, 2019
| init.flags= I2C_FLAG_WRITE; | ||
|
|
||
|
|
||
| ret=I2CSPM_Transfer(I2C0,&init); |
There was a problem hiding this comment.
@PuneetBansal why use a blocking transfer here instead of interrupt driven?
dwalkes
commented
Apr 22, 2019
|
|
||
| /*Write operation to transfer slave address and type of data required*/ | ||
| i2c_write(init,1); | ||
| timerWaitUs(10000); |
There was a problem hiding this comment.
@PuneetBansal use a state machine for low power implementation, don't use inline waits here.
There was a problem hiding this comment.
This applies generally to inline waits below as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.