Patcher bg music #100
Closed
Patcher bg music #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was throwing ts compilation errors - not able to delete readonly properties. Use es6 object destructuring instead.
`componentDidUnMount` should be `componentWillUnmount`
Since music is stateful (vs a sound that is played once), I used redux to handle playing music.
|
Ugh just realized I must have had an old copy of |
codecorsair
reviewed
Mar 24, 2017
| */ | ||
|
|
||
| import * as React from 'react'; | ||
| interface AudioProps extends React.HTMLProps<HTMLAudioElement> { |
There was a problem hiding this comment.
The interface needs to be exported as well here
| @@ -268,4 +274,4 @@ class PatchButton extends React.Component<PatchButtonProps, PatchButtonState> { | |||
| } | |||
| } | |||
|
|
|||
| export default PatchButton; | |||
| export default connect()(PatchButton); | |||
There was a problem hiding this comment.
What is the purpose of this connect? The component should not be wrapping in a connect call, if you just want dispatch in the component accept the function as a prop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #99
Note this isn't ready yet, just wanted some feedback for a few things.
I'm using redux actions to handle playing music since it's more stateful than sounds. The first point in the issue is fully working. However it looks like
Controller(and the other components inwidgets) are using a different store than thepatcher`. This means we can't dispatch actions across these components. What's the reason they're all using different stores?