fix(ui): correctly match negation in app report#3438
fix(ui): correctly match negation in app report#3438Y4nnikH wants to merge 9 commits intoCactuseSecurity:developfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses error handling in JavaScript interop calls and fixes negation logic in database tenant visibility functions. The changes improve robustness by preventing JavaScript exceptions from crashing the UI and correct the logic for matching negated rules in app reports.
- Adds try/catch blocks around JavaScript interop calls to handle JSException gracefully
- Fixes negation matching logic in SQL functions by removing incorrect rule-level negation checks
- Simplifies database queries by removing unnecessary JOIN operations with the rule table
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| AnchorNavToRSB.razor | Adds exception handling around JavaScript interop calls to prevent crashes |
| fworch-api-funcs.sql | Fixes negation logic and removes unnecessary JOINs in tenant visibility functions |
tpurschke
left a comment
There was a problem hiding this comment.
-
rules report still working correctly
-
AppRule report still shows rules with negated parts incorrectly:
eg. a rule containing "not rfc1918_netze" (containing 10.0.0.0/8) in destination is shown for an application that only has addresses starting with 10.x
|
|
@dependabot recreate |




fixes #3349