Skip to content

Conversation

huskier
Copy link
Contributor

@huskier huskier commented Aug 28, 2025

Resolved a ZeroDivisionError in the sketch hull algorithm that occurred when processing overlapping geometries.

Applying the fix will allow the code below to execute as intended.

import cadquery as cq
from cadquery.vis import show

sketch = (cq.Sketch()
          .push([(44,0)])
          .rect(40, 40)
          .reset()
          .push([(82, 0)])
          .circle(20)
          .reset()
          .hull())
		  
show(sketch)

Resolved a ValueError in the sketch hull algorithm that occurred when processing overlapping geometries.
Copy link

codecov bot commented Aug 28, 2025

Codecov Report

❌ Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.66%. Comparing base (0c0a661) to head (c26869e).

Files with missing lines Patch % Lines
cadquery/hull.py 25.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1889      +/-   ##
==========================================
- Coverage   95.74%   95.66%   -0.08%     
==========================================
  Files          29       29              
  Lines        7583     7591       +8     
  Branches     1141     1144       +3     
==========================================
+ Hits         7260     7262       +2     
- Misses        193      196       +3     
- Partials      130      133       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant