Skip to content

Comments

feat: merge base into develop#16

Merged
abdosharaf9 merged 103 commits intodevelopfrom
base-structure
May 10, 2025
Merged

feat: merge base into develop#16
abdosharaf9 merged 103 commits intodevelopfrom
base-structure

Conversation

@abdosharaf9
Copy link
Collaborator

@abdosharaf9 abdosharaf9 commented May 10, 2025

Implemented Functionalities

  • The user can choose from a predefined list or enter the city name they want.
  • Fetch the location of the city, and use it to fetch the current weather data.
  • Use the weather parameters, such as the temperature and the time, to suggest the clothes.
  • The suggestions are printed out in the console in a user-friendly way.
  • Handle the exceptions using custom exceptions with informative messages.

abdosharaf9 and others added 30 commits May 4, 2025 23:37
@abdosharaf9
feat: add coroutines and ktor dependencies
f76714c
@abdosharaf9
feat: add serialization dependencies
60ae2a1
@abdosharaf9
feat: add initial logic for get city location by name use case
f03283d
@mohgalal
feature: add 2 test cases for get current weather use case
6f420ab
@mohgalal
feature: add exception classes in data layer
d34223c
@abdosharaf9
feat: add test cases for get city location by name use case
3504b46
@abdosharaf9
feat: implement get city location by name use case
48d299e
@mohgalal
feature: add more test cases TDD
f0c05fb
@abdosharaf9
feat: add ktor client in remote data source
f273d54
@mohgalal
feature: add get weather use case implementation
60f6d93
@abdosharaf9
Merge branch 'base-structure' into feature/get-city-location
fa1f663
@abdosharaf9
fix: change wrong attribute name in the response
f60d38a
@abdosharaf9
feat: implement city location mapper
1fb64ed
@abdosharaf9
feat: implement get city location by name in repository and data source
fdaab62
@mohgalal
refactor: enhance and edit some lines of codes based on PRs
72e62db
@abdosharaf9
refactor: improve city location mapper readability
d35a955
@abdosharaf9
refactor: rename the main function in get city location by name use case
536b898
@norhanadel367
feat: create ClothingSuggestion use case , write unit test base TDD
908f8a1
@norhanadel367
feat: implementation suggestClothes
8846905
@mohgalal
feat: add CurrentWeatherMapper implementation
9b123b2
@norhanadel367
feat: edite formatting file
f1fffbf
@mohgalal
Merge branch 'base-structure' into feature/get-weather
8240e29
@norhanadel367
feat: rename function
02d8a54
@norhanadel367
feat: rename var temp to temperature
ab42533
@norhanadel367
feat: rename function
64a35d7
@norhanadel367
feat: rename clas add keyword use case and formating file
90dcb2a
@abdosharaf9
Merge pull request #3 from Cairo-Squad/feature/get-city-location
64a2835 
feature: implement get city location using city name use case
@abdosharaf9
feat: add base ui classes
1bf4215
@norhanadel367
refactor: create WeatherConstants and improve in ClothingSuggestionUs…
d49543b 
…eCase
@norhanadel367
refactor: delete class FakeData.kt and add fake data in unite test
641383e
abdosharaf9 and others added 23 commits May 9, 2025 17:42
@abdosharaf9
fix: remove the unnecessary and broke test case
e31b0b2
@abdosharaf9
Merge remote-tracking branch 'origin/base-structure' into refactor
084d32d
@norhanadel367
refactor: using kotlinx.datetime not java.time.LocalTime . inject rep…
d2200d7 
…o in ClothingSuggestionUseCase
@abdosharaf9
Merge pull request #14 from Cairo-Squad/refactor
79df5b0 
refactor: change all the required changes
@abdosharaf9
refactor: remove validation for the use case arguments
9a47d94
@abdosharaf9
refactor: remove unused exception
53e2c77
@abdosharaf9
refactor: change the mapping logic, make all logic models attributes …
4959416 
…have default values, and move wrap function to the repository
@norhanadel367
refactor : add fun filterClothes in repo to filter clothes in Clothin…
627db1d 
…gSuggestionUseCase
@norhanadel367
refactor :edite fun suggestClothes , move filteration getTimeOfDay ,
2f1fa63 
getWeatherTag in WeathersUtils in logic .  inject clothingSuggestionRepository in use case.
@norhanadel367
refactor : convert hardcode eith constants , add fun filterClothes
13a1f17
@norhanadel367
refactor: make SuggestionClothes nullable value
e2a4120
@norhanadel367
refactor: edit unit test to make weathersUtils mockk,and mockk weathe…
e8448bc 
…rRepository ,edite test case based it
@norhanadel367
Merge remote-tracking branch 'origin/base-structure' into feature/clo…
570f7e4 
…thing-suggestion

# Conflicts:
#	src/main/kotlin/data/repository/WeatherRepositoryImpl.kt
#	src/main/kotlin/logic/usecase/ClothingSuggestionUseCase.kt
#	src/main/kotlin/logic/utils/Exceptions.kt
@norhanadel367
refactor: refactor some naming
43f2f98
@abdosharaf9
Merge pull request #13 from Cairo-Squad/feature/clothing-suggestion
9099169 
refactor: remove all hardcoded values from clothes suggestion use case
@abdosharaf9
Merge remote-tracking branch 'origin/base-structure' into refactor
a0e1cb3 
# Conflicts:
#	src/main/kotlin/data/repository/WeatherRepositoryImpl.kt
@abdosharaf9
feat: add abstraction for the clothes suggestion data source
f9d510c
@abdosharaf9
refactor: make no clothes found exception inherited from the app exce…
d73c8b6 
…ption
@abdosharaf9
refactor: combine get city location and get current weather use cases…
f577975 
… into a single one
@abdosharaf9
refactor: print city name with the suggestions
f3b18a1
@abdosharaf9
Merge pull request #15 from Cairo-Squad/refactor
4b18e4c 
refactor: complete the requested changes
@abdosharaf9
feat: add Kover workflow to run test coverage on PRs (#12)
4b250e2
@abdosharaf9
Merge remote-tracking branch 'origin/develop' into base-structure
dcdbe3e
@abdosharaf9 abdosharaf9 requested a review from Shehab-m May 10, 2025 08:35
@github-actions
Copy link

github-actions bot commented May 10, 2025

✅ Kover Test Coverage

  • Coverage: 100%
  • Minimum required: 100%
  • Only logic package is checked.

@abdosharaf9 abdosharaf9 merged commit debeb8e into develop May 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Shehab-m Shehab-m Shehab-m approved these changes

Assignees

@mohgalal mohgalal

@abdosharaf9 abdosharaf9

@norhanadel367 norhanadel367

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@abdosharaf9 @Shehab-m @mohgalal @norhanadel367